Autosave locally

[Bellavene]

The tutorial and help options state this:

In the settings.json file you can also put set options locally by specifying
either a glob or a filetype. Here is an example which has `tabstospaces` on for
all files except Go files, and `tabsize` 4 for all files except Ruby files:

json
{
    "ft:go": {
        "tabstospaces": false
    },
    "ft:ruby": {
        "tabsize": 2
    },
    "tabstospaces": true,
    "tabsize": 4
}

Or similarly you can match with globs:

json
{
    "*.go": {
        "tabstospaces": false
    },
    "*.rb": {
        "tabsize": 2
    },
    "tabstospaces": true,
    "tabsize": 4
}

But it doesn't work with autosave option, starting micro with micro -autosave 1 doesn't work either... I see that this isn't working at least 4-5 years, why?

[Andriamanitra]

Enabling autosave works fine for me both from command line and settings.json. Can you provide more information (micro -version, operating system, how did you figure out it's "not working")?

[Bellavene]

2.0.14-dev.201
macos 10.14.4

No need to quote my statement. I am not talking about global autosave, which works fine if toggled with settings.json, but still doesn't work from prompt. If you look closely, I am talking about local setting.

[Andriamanitra]

I see the issue now: autosave currently only works as a global option, and we only have one global Autosave timer that triggers save on all open buffers regardless of their potentially different local autosave setting.
https://github.com/zyedidia/micro/blob/650c0a8db0dc755a363abf2f697e3f3122dd2da3/cmd/micro/micro.go#L421-L424

I can think of a few ways of fixing this:

1. Give each buffer its own autosave timer (probably a bad idea?)
2. Change the global timer to always trigger every second, but add checks for buffer-local autosave interval settings
3. Completely rework the autosave system – the whole timer thing seems a bit odd to me as it triggers on a regular interval. Is there any reason to want that behavior instead of simply saving after the buffer is modified?

starting micro with micro -autosave 1 doesn't work either

This part I still can't reproduce though. How did you figure out it's not working?

[Bellavene]

I believe option 3 is the right way. And yes, I don't see the logic in autosave on every change that was made, autosave on exit sounds more logical, when we already have backups.
But why not bring back local execution? And why the tutorial still says about it, when it doesn't work?

This part I still can't reproduce though. How did you figure out it's not working?

Strange question, It doesn't auto save : ) I would be happy with the variable option only available, I need autosave only for CLI messaging apps anyway.

Screen.Recording.2024-06-13.at.08.59.16.mov

[JoeKar]

That's very strange. I can see, that it isn't working for you, but currently I can't reproduce it in that way under Linux.
Do you have autosave set to true in your settings.json?
Because there is this downward compatible check:
https://github.com/zyedidia/micro/blob/55f45ce8ff08a7ede4d4a125c8ea06de5da9da61/internal/config/settings.go#L175-L185

Anyway I tested it with it being set to true and even then it wasn't waiting 8s.

[Bellavene]

That's very strange. I can see, that it isn't working for you, but currently I can't reproduce it in that way under Linux.
Do you have autosave set to true in your settings.json?

Nope, as I said before, I don't need global autosave. Yes, it is strange.

I found which setting in init.lua was causing dysfunctional autosave variable. Still can't imagine why this function is overriding the variable at start.

function onBufferOpen(buf)
    if buf.Settings["filetype"] == "unknown" then
        buf:SetOption("filetype", "zsh")
    end
end

[JoeKar]

Aaah, ok...now it becomes clear:
https://github.com/zyedidia/micro/blob/650c0a8db0dc755a363abf2f697e3f3122dd2da3/internal/buffer/settings.go#L22-L33

The call to config.InitGlobalSettings() will actually revert the volatile settings.

[JoeKar]

Feel free to apply the patch from the linked PR and test if it now fits to your expectation.

[Bellavene]

Thanks

[Bellavene]

But still, autosave on exit would be better, I believe.

[JoeKar]

It does exactly that in the moment autosave isn't overwritten by 0:
https://github.com/zyedidia/micro/blob/55f45ce8ff08a7ede4d4a125c8ea06de5da9da61/internal/action/actions.go#L1645-L1649

[Bellavene]

Feel free to apply the patch from the linked PR and test if it now fits to your expectation.

Tested, nothing has changed. Variable still doesn't work if you change the file type for buffer in init.lua