brew install micro --HEAD stopped working

[Bellavene]

A month ago the --HEAD installation option stopped working.

brew install micro --HEAD

==> Upgrading micro
  HEAD-3737979 -> HEAD-968f5ba 
==> make build-tags
Last 15 lines from /Users/User/Library/Logs/Homebrew/micro/01.make:
2024-08-29 12:40:23 +0000

make
build-tags

git fetch --tags
GOOS=darwin GOARCH=arm64 go generate ./runtime
From https://github.com/zyedidia/micro
 ! [rejected]          nightly     -> nightly  (would clobber existing tag)
 * [new tag]           v2.0.14     -> v2.0.14
 * [new tag]           v2.0.14-rc1 -> v2.0.14-rc1
make: *** [fetch-tags] Error 1

[JoeKar]

Looks like an side effect of #3334, which moves the tag nightly every day to the HEAD of the master branch.

Currently I assume that this is more an issue of the formula (micro.rb) provided for brew to install micro:
https://github.com/Homebrew/homebrew-core/blob/d248edd51c930378ed56d7b2a9b7f1ddd0c96754/Formula/m/micro.rb#L23

Does it really need to call build-tags from micro's Makefile? It results in fetching all tags, which fails in the moment it isn't forced to overwrite, since the same tag is already present locally with a different hash.

I think the only statement in this line should be system "make", "build".

[zyedidia]

I think the build-tags is necessary to fetch any new tags so that the version number gets compiled properly (2.0.14-dev.X). Maybe the build-tags make target should use --force so that it can clobber the nightly tag?

[zyedidia]

Alternatively the formula could be updated to manually run the git fetch --tags --force before running make. That way the formula can be updated without needing a new archive of the source code.

[JoeKar]

I think the build-tags is necessary to fetch any new tags so that the version number gets compiled properly (2.0.14-dev.X). Maybe the build-tags make target should use --force so that it can clobber the nightly tag?

Yes, you're right. Without the (newest) tags the build process isn't able to create the relative version number (correctly). Although I think this relative version number doesn't help that much, while the commit hash does. I assume no one will count the commits from the last tag to find the right one, when the hash is already available. 😉

Alternatively the formula could be updated to manually run the git fetch --tags --force before running make. That way the formula can be updated without needing a new archive of the source code.

Then a normal make build would be feasible enough.

The more I think about it the more I tend to "fix" both use cases. The build-tags make target already exists and doesn't work in environments where nightly has changed while it's present.

[JoeKar]

@Bellavene
Could you be so kind and help to test the change prepared for homebrew (see the steps in the linked PR).

[Bellavene]

Yes, thank you. brew install micro --fetch-HEAD did the trick

[JoeKar]

I was referring to the 3 open checkpoints in Homebrew/homebrew-core#183045. Have you performed these steps with the PR applied locally in your homebrew-core repository? 😉

[Bellavene]

@JoeKar
Oh sorry, was in work and totally lost your request...
And brew install micro --fetch-HEAD doesn't install latest commits again.