Fix unneeded rewriting of settings.json#3009
Merged
dmaluka merged 4 commits intomicro-editor:masterfrom Mar 14, 2024
Merged
Conversation
Apply the same fix as 4d13308 to all kinds of options, not just to plugin options.
Avoid code duplication between RegisterCommonOption() and RegisterCommonOptionPlug(), exactly the same way as it is done for RegisterGlobalOption() and RegisterGlobalOptionPlug().
It doesn't seem necessary to write settings to settings.json when registering a new option. The option is set to its default value, which means that it will not be written to settings.json (precisely because it's the default value), so the contents of settings.json don't change and thus don't need to be written again. This unneeded writing, in particular, causes unexpected "The file on disk has changed. Reload file? (y,n,esc)" each time when we open settings.json via micro. Fixes micro-editor#2647
JoeKar
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't seem necessary to write settings to settings.json when registering a new option. The option is set to its default value, which means that it will not be written to settings.json (precisely because it's the default value), so the contents of settings.json don't change and thus don't need to be written again.
This unneeded writing, in particular, causes unexpected "The file on disk has changed. Reload file? (y,n,esc)" each time when we open settings.json via micro.
Fixes #2647
As a bonus, a few other small fixes and code improvements.