Skip to content

Comments

util: Fix opening filenames including colons with parsecursor#3119

Merged
zyedidia merged 1 commit intomicro-editor:masterfrom
JoeKar:fix/filename-with-colon
Mar 4, 2024
Merged

util: Fix opening filenames including colons with parsecursor#3119
zyedidia merged 1 commit intomicro-editor:masterfrom
JoeKar:fix/filename-with-colon

Conversation

@JoeKar
Copy link
Member

@JoeKar JoeKar commented Jan 15, 2024

The regex pattern shall search for the end of the filename first as it does while opening with +LINE:COL.

In https://github.com/zyedidia/micro/blob/master/cmd/micro/micro.go#L172 we check for the end of the string as well.

Fixes #3118

The regex pattern shall search for the end of the filename first as it does
while opening with +LINE:COL.
@JoeKar
Copy link
Member Author

JoeKar commented Jan 15, 2024

Unfortunately the root cause of #1650 still applies in the moment parsecursor is active and the file is called e.g. file:123 or file:123:321 respective ends with :NUMBER.
It's arguable a problem in the moment valid file names are parsed and become "invalid".

@JoeKar
Copy link
Member Author

JoeKar commented Jan 30, 2024

The macos build simply failed by builder timeout. Nothing special, just needs a kick...

@zyedidia zyedidia merged commit eedebd8 into micro-editor:master Mar 4, 2024
@JoeKar JoeKar deleted the fix/filename-with-colon branch March 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Micro cannot open files with colon in their name

2 participants