util: Fix opening filenames including colons with parsecursor#3119
Merged
zyedidia merged 1 commit intomicro-editor:masterfrom Mar 4, 2024
Merged
util: Fix opening filenames including colons with parsecursor#3119zyedidia merged 1 commit intomicro-editor:masterfrom
parsecursor#3119zyedidia merged 1 commit intomicro-editor:masterfrom
Conversation
The regex pattern shall search for the end of the filename first as it does while opening with +LINE:COL.
Member
Author
|
Unfortunately the root cause of #1650 still applies in the moment |
Member
Author
|
The macos build simply failed by builder timeout. Nothing special, just needs a kick... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex pattern shall search for the end of the filename first as it does while opening with +LINE:COL.
In https://github.com/zyedidia/micro/blob/master/cmd/micro/micro.go#L172 we check for the end of the string as well.
Fixes #3118