infocomplete: Complete filetypes (follow-up)#3218
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Mar 27, 2024
Merged
infocomplete: Complete filetypes (follow-up)#3218JoeKar merged 2 commits intomicro-editor:masterfrom
JoeKar merged 2 commits intomicro-editor:masterfrom
Conversation
JoeKar
force-pushed
the
fix/complete-filetype
branch
from
c47830e to
2ea70f5
Compare
dmaluka
added a commit
to dmaluka/micro
that referenced
this pull request
Mar 26, 2024
This typo causes a funny bug: the autodetected filetype for *.jsonnet files is an empty string instead of "jsonnet". Even funnier, when autocompleting "set filetype " (with the fix from PR micro-editor#3218), the first suggested filetype is this empty string.
dmaluka
reviewed
Mar 26, 2024
The first shot of the feature unfortunately completed the *.yaml file names instead of the included filetypes. This will be corrected with this follow up.
… hint Co-authored-by: Dmytro Maluka <dmitrymaluka@gmail.com>
JoeKar
force-pushed
the
fix/complete-filetype
branch
from
2ea70f5 to
9eb93fc
Compare
dmaluka
approved these changes
Mar 26, 2024
dmaluka
added a commit
that referenced
this pull request
Mar 28, 2024
This typo causes a funny bug: the autodetected filetype for *.jsonnet files is an empty string instead of "jsonnet". Even funnier, when autocompleting "set filetype " (with the fix from PR #3218), the first suggested filetype is this empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first shot of the feature unfortunately completed the *.yaml file names instead of the included filetypes. This will be corrected with this follow up.
Fixes #3215