Add syntax highlighting for meson build system#3236
Add syntax highlighting for meson build system#3236JoeKar merged 7 commits intomicro-editor:masterfrom
Conversation
It is basically a port of upstream syntax highlighting for vim, but a bit less noisy (e.g numbers are not colored).
I think it's fine to highlight numbers and symbols, since users chould choose a colorscheme like I'm inexperienced with syntax files but based on examples and the link in the file, maybe this could be added: - constant.number: "\\b(0|[1-9][0-9]*|0b[01]+|0o[0-7]+|0x[0-9a-fA-F]+)\\b"
- symbol: ','
- symbol.operator: "[-+*/%?.:=!+<>]"
- symbol.brackets: "[(){}]|\\[|\\]"@Andriamanitra |
Andriamanitra
left a comment
There was a problem hiding this comment.
I'm not familiar with meson but I tried it with a couple meson files and it seems to work alright.
|
Hi, sorry for the delayed reply. I almost forgot about this PR. I will look into it when I have time. |
|
I don't think you should be the one apologizing, considering that this PR received no attention for a long period of time. I've actually used your syntax file sometimes to view Meson build files, but wasn't sure when to properly review it myself. However it would still be appreciated if it's fine with you to address the comments, so that this can now be merged and included by default. |
|
Hi, @niten94 , @Andriamanitra could you please have another look? |
|
The problem with reviews resp. approvals of non-maintainers is, that they aren't included in the filtered search: This will most probably hit a lot more PRs where the community gave their approval. Anyway, I will have a short look. |
It is basically a port of upstream syntax highlighting for vim, but a bit less noisy (e.g numbers are not colored).