bindings: Correct KeySequenceEvent comparison (fix crash)#3266
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Apr 26, 2024
Merged
bindings: Correct KeySequenceEvent comparison (fix crash)#3266JoeKar merged 2 commits intomicro-editor:masterfrom
KeySequenceEvent comparison (fix crash)#3266JoeKar merged 2 commits intomicro-editor:masterfrom
Conversation
JoeKar
force-pushed
the
fix/keysequence-comparison
branch
from
a516ebd to
8ded4c1
Compare
dmaluka
reviewed
Apr 25, 2024
JoeKar
force-pushed
the
fix/keysequence-comparison
branch
from
8ded4c1 to
6be193d
Compare
dmaluka
reviewed
Apr 25, 2024
We've to iterate over the included elements, since slices can't be simply compared with the comparison operators.
JoeKar
force-pushed
the
fix/keysequence-comparison
branch
from
6be193d to
b05df07
Compare
dmaluka
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've to iterate over the included elements, since slices can't be simply compared with the comparison operators.
Fixes #3194