Fix cursor moving to an unexpected location after a redo#3416
Merged
dmaluka merged 2 commits intomicro-editor:masterfrom Aug 15, 2024
Merged
Fix cursor moving to an unexpected location after a redo#3416dmaluka merged 2 commits intomicro-editor:masterfrom
dmaluka merged 2 commits intomicro-editor:masterfrom
Conversation
Remember the cursor location in TextEvent just once - when the original text event happens, so that when we redo after an undo, the cursor is placed at the location where the actual redone modification happens (as the user would expect), not at the location where the cursor was before the undo (which may be a completely unrelated location and may be far away). Fixes micro-editor#3411
Collaborator
Author
|
AFAICS this changing of the remembered cursor location (removed by this PR) was added intentionally in aabc81e. The commit message says just "Fix bugs with undo/redo" so perhaps this |
JoeKar
approved these changes
Aug 5, 2024
Member
JoeKar
left a comment
JoeKar
left a comment
There was a problem hiding this comment.
From behavioral point of view it's now comprehensible.
dmaluka
added a commit
to dmaluka/micro-detectindent
that referenced
this pull request
Aug 9, 2024
Setting options directly in buf.Settings without calling SetOption() or SetOptionNative() is generally not the best idea, since it may not trigger the needed side effects. In particular, after micro-editor/micro#3416, directly setting `tabstospaces` and `tabsize` causes them not being tracked as locally overridden per buffer, so if we run the `reload` command, it unexpectedly replaces the autodetected `tabstospaces` and `tabsize` settings with the default ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remember the cursor location in
TextEventjust once - when the original text event happens, so that when we redo after an undo, the cursor is placed at the location where the actual redone modification happens (asthe user would expect), not at the location where the cursor was before the undo (which may be a completely unrelated location and may be far away).
Fixes #3411