Fix non-working raw escape bindings after restarting the screen#3468
Merged
JoeKar merged 1 commit intomicro-editor:masterfrom Sep 12, 2024
Merged
Fix non-working raw escape bindings after restarting the screen#3468JoeKar merged 1 commit intomicro-editor:masterfrom
JoeKar merged 1 commit intomicro-editor:masterfrom
Conversation
When we temporarily disable the screen (e.g. during RunInteractiveShell) and then enable it again, we reinitialize tcell.Screen from scratch, so we need to register all previously registered raw escape sequences once again. Otherwise raw escape bindings stop working, since the list of raw escape sequences of this newly create tcell.Screen is empty. Fixes micro-editor#3392
dmaluka
force-pushed
the
rawseq-screen-restart-fix
branch
from
ac3bc93 to
13c7178
Compare
JoeKar
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we temporarily disable the screen (e.g. during
RunInteractiveShell) and then enable it again, we reinitializetcell.Screenfrom scratch, so we need to register all previously registered raw escape sequences once again. Otherwise raw escape bindings stop working, since the list of raw escape sequences of this newly createtcell.Screenis empty.Fixes #3392