Skip to content

Comments

Add target for Windows ARM64 in cross-compile.sh#3512

Merged
JoeKar merged 2 commits intomicro-editor:masterfrom
creeperlv:patch-2
Oct 21, 2024
Merged

Add target for Windows ARM64 in cross-compile.sh#3512
JoeKar merged 2 commits intomicro-editor:masterfrom
creeperlv:patch-2

Conversation

@creeperlv
Copy link
Contributor

It seems other scripts in tools folder isn't being used by GitHub Workflow, hence, leaving them alone.
You can check my builds using GitHub Workflow and building natively in my repo. They work on my Windows on Arm computers.


echo "Windows ARM64"
GOOS=windows GOARCH=arm64 make build
create_artefact_windows "winarm64"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: win-arm64? (Just for consistency with other target names: linux-arm64, macos-arm64)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to win-arm64 now, please check the newest commit. :)

Add target for Windows ARM64 in cross-compile.sh

Update windows arm64 target to match existing patterns.
@dmaluka
Copy link
Collaborator

dmaluka commented Oct 20, 2024

I have no objections to adding this, although I have no chance to test it. @JoeKar dunno, maybe you can?

@creeperlv
Copy link
Contributor Author

Here is a screenshot of micro built by myself running on my Snapdragon Laptop
image

@JoeKar
Copy link
Member

JoeKar commented Oct 21, 2024

I have no objections to adding this, although I have no chance to test it. @JoeKar dunno, maybe you can?

I've no big troubles with this change too, but I can't test it myself, since I've no Windows on ARM64 device.
But luckily @creeperlv already tested it for us on his device.

After the small mentioned white-space change we can merge it and @creeperlv maybe can test it directly with the newest nightly including this binary. :)

Co-authored-by: Jöran Karl <3951388+JoeKar@users.noreply.github.com>
@creeperlv
Copy link
Contributor Author

creeperlv commented Oct 21, 2024

After the small mentioned white-space change we can merge it and @creeperlv maybe can test it directly with the newest nightly including this binary. :)

Of course, it's micro is my daily driver, I even made it default app for many file types. ;)

@JoeKar JoeKar merged commit 3cb8069 into micro-editor:master Oct 21, 2024
@creeperlv creeperlv deleted the patch-2 branch October 21, 2024 17:33
@creeperlv
Copy link
Contributor Author

Just want to share a screenshot of latest nightly running on my Snapdragon Laptop here. :D
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants