Skip to content

Comments

Nftables improvements#3517

Merged
JoeKar merged 2 commits intomicro-editor:masterfrom
theredcmdcraft:nftables-improvements
Jun 20, 2025
Merged

Nftables improvements#3517
JoeKar merged 2 commits intomicro-editor:masterfrom
theredcmdcraft:nftables-improvements

Conversation

@theredcmdcraft
Copy link
Contributor

@theredcmdcraft theredcmdcraft commented Oct 22, 2024

See also old PR: #3325

@theredcmdcraft theredcmdcraft mentioned this pull request Oct 22, 2024
Merged
JoeKar
JoeKar reviewed Oct 23, 2024
View reviewed changes
JoeKar
JoeKar requested changes Dec 1, 2024
View reviewed changes
JoeKar
JoeKar requested changes Dec 2, 2024
View reviewed changes
JoeKar
JoeKar reviewed Dec 4, 2024
View reviewed changes
JoeKar
JoeKar reviewed Dec 28, 2024
View reviewed changes
JoeKar
JoeKar reviewed Dec 29, 2024
View reviewed changes
@theredcmdcraft theredcmdcraft requested a review from JoeKar April 4, 2025 13:10
@theredcmdcraft
Copy link
Contributor Author

theredcmdcraft commented May 27, 2025

@JoeKar can you have a look on the file again, that we can finish this PR?

@JoeKar
Copy link
Member

JoeKar commented May 27, 2025 •
edited
Loading

I can, but can you please answer my question in #3517 (comment)?
Please do not merge the master into your feature branch, but rebase your feature branch against the upstream master. This will keep the PR commit history clean.

@theredcmdcraft
Copy link
Contributor Author

theredcmdcraft commented May 27, 2025

Ohhh ooops. i think that was wrong...

@theredcmdcraft
Copy link
Contributor Author

theredcmdcraft commented May 27, 2025

I can, but can you please answer my question in #3517 (comment)?

I don`t know what my intent was. The commit where i changed this line is from November 30th, 2024. It is some time ago. sorry

@theredcmdcraft theredcmdcraft force-pushed the nftables-improvements branch from bd3bfd8 to b9d7109 Compare May 27, 2025 20:36
@theredcmdcraft
Copy link
Contributor Author

theredcmdcraft commented May 27, 2025

I think that looks a little bit better. Sorry for stupidity.

@JoeKar
Copy link
Member

JoeKar commented May 28, 2025

I think that looks a little bit better. Sorry for stupidity.

Not really, there are 64 changed files, while there should be only one.

@JoeKar
Copy link
Member

JoeKar commented May 28, 2025

I can, but can you please answer my question in #3517 (comment)?

I don`t know what my intent was. The commit where i changed this line is from November 30th, 2024. It is some time ago. sorry

When there is no use case it, why keep it?

@theredcmdcraft theredcmdcraft force-pushed the nftables-improvements branch from 82db21e to 5eddf5b Compare June 15, 2025 15:11
@JoeKar JoeKar merged commit 97b5e35 into micro-editor:master Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeKar JoeKar JoeKar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theredcmdcraft @JoeKar