import: Use mattn/go-runewidth instead of zyedidia/go-runewidth#3601
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Jan 6, 2025
Merged
import: Use mattn/go-runewidth instead of zyedidia/go-runewidth#3601JoeKar merged 2 commits intomicro-editor:masterfrom
mattn/go-runewidth instead of zyedidia/go-runewidth#3601JoeKar merged 2 commits intomicro-editor:masterfrom
Conversation
Andriamanitra
approved these changes
Jan 5, 2025
Contributor
Andriamanitra
left a comment
Andriamanitra
left a comment
There was a problem hiding this comment.
This also fixes #3264 as the upstream version now includes Unicode 15 support
Collaborator
|
It would be worth mentioning in the PR description that both our downstream changes zyedidia/go-runewidth#1 and zyedidia/go-runewidth#2 were merged upstream in mattn/go-runewidth#44 and mattn/go-runewidth#47. |
dmaluka
approved these changes
Jan 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream version includes the changes added on top after the fork of
zyedidia/go-runewidth.#3601 (comment):
Fixes #3264