Add missing resize in TabMove#3619
Merged
JoeKar merged 1 commit intomicro-editor:masterfrom Jan 28, 2025
Merged
Conversation
Contributor
|
I wanted to report this the other day, but I didn't have time. If you use When you open 2 tabs and move the right one to the left with |
Contributor
|
(For documentation purposes) |
dmaluka
reviewed
Jan 25, 2025
internal/action/command.go
Outdated
| Tabs.List[idxTo] = activeTab | ||
| Tabs.UpdateNames() | ||
| Tabs.SetActive(idxTo) | ||
| Tabs.Resize() |
Collaborator
There was a problem hiding this comment.
nit: move it before Tabs.UpdateNames(), to keep it consistent with the code in AddTab() and RemoveTab()?
Neko-Box-Coder
force-pushed
the
FixTabMove
branch
from
dc3ad34 to
15454c2
Compare
dmaluka
approved these changes
Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you create 2 scratched buffers tabs (just new tabs), do
tabswitch 2, then perform atabmove 1(ortabmove 2, doesn't matter), and then go to the next/prev tab, the tab bar will disappear when selecting one of the tabs.I didn't fully figure out why it happens but it seems like it is missing a Resize to update the tab sizes. This patch fixes that.