Skip to content

plugin: linter: add ruff to default configuration.#3656

Closed
ghost wants to merge 3 commits intomasterfrom
unknown repository
Closed

plugin: linter: add ruff to default configuration.#3656
ghost wants to merge 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Feb 6, 2025

Hi,
Just adding ruff to the micro linter plugin configuration.

Copy link
Contributor

@Andriamanitra Andriamanitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition. ruff has become one of the standard tools for linting and formatting Python code so it makes sense to add it as one of the default linters.

Use `--output-format concise` as suggested to get exact column of error

Co-authored-by: Mikko <Andriamanitra@users.noreply.github.com>
Copy link
Member

@JoeKar JoeKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a good moment to synchronize the doc again to the default list present in the linter.lua:
https://github.com/zyedidia/micro/blob/b432bb7cfafa9a1c07acdf28eba8eb87c67b6793/runtime/plugins/linter/help/linter.md?plain=1#L8-L25
😉

@JoeKar
Copy link
Member

JoeKar commented Feb 7, 2025

Am I right, that we execute on a pure default setup every available linter per filetype match in a row?
https://github.com/zyedidia/micro/blob/b432bb7cfafa9a1c07acdf28eba8eb87c67b6793/runtime/plugins/linter/linter.lua#L131-L139

Should we add a check to stop after the first successful execution and on top of that should we add a priority for more than one available linter in the default list/map?

@ghost ghost closed this by deleting the head repository Feb 7, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants