sh.yaml: Match valid parameter expansions without braces#3663
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Feb 27, 2025
Merged
sh.yaml: Match valid parameter expansions without braces#3663JoeKar merged 2 commits intomicro-editor:masterfrom
sh.yaml: Match valid parameter expansions without braces#3663JoeKar merged 2 commits intomicro-editor:masterfrom
Conversation
matthias314
reviewed
Feb 14, 2025
Match parameter expansions with valid name only in shell syntax file when there are no braces.
niten94
force-pushed
the
sh-separate-paramexp
branch
from
90a85c4 to
4abd966
Compare
JoeKar
reviewed
Feb 16, 2025
niten94
force-pushed
the
sh-separate-paramexp
branch
from
2686a6d to
0985d2c
Compare
JoeKar
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, text not parsed in
shas part of a name in parameter expansions without braces are changed to not be highlighted together.In
sh, there is no expansion format other than$parameterwhen there are no braces. Names cannot begin with a digit but positional parameters with one digit can be specified.Fixes #3660