Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test framework & refactor RPC server #2579

Merged
merged 15 commits into from
Oct 20, 2022
Merged

feat: add test framework & refactor RPC server #2579

merged 15 commits into from
Oct 20, 2022

Conversation

Davincible
Copy link
Contributor

No description provided.

@Davincible Davincible changed the title fix: refactor RPC server part 1 fix: refactor RPC server Oct 3, 2022
@jochumdev
Copy link
Contributor

Looks like everything is cleaner now, server/rpc_server.go changes are so big that they are hard to understand on the first sight.

@Davincible
Copy link
Contributor Author

Looks like everything is cleaner now, server/rpc_server.go changes are so big that they are hard to understand on the first sight.

rpc_server.go is one massive file with massive functions. Trying to break it up to make it more digestable.

@Davincible
Copy link
Contributor Author

Davincible commented Oct 7, 2022 •
edited
Loading

todo: don't retry on business logic error
Edit: done

@Davincible Davincible changed the title fix: refactor RPC server feat: add test framework & refactor RPC server Oct 20, 2022
@Davincible Davincible marked this pull request as ready for review October 20, 2022 11:00
@Davincible Davincible merged commit a3980c2 into master Oct 20, 2022
@Davincible Davincible deleted the refactor-rpc-server branch October 20, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochumdev jochumdev Awaiting requested review from jochumdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Davincible @jochumdev