handle redis.Nil error properly #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Richter <crichter@owncloud.com>
butonic
approved these changes
May 9, 2023
There was a problem hiding this comment.
ouch, I accidentially dropped this in https://github.com/go-micro/plugins/pull/97/files#diff-dbd8c1ee4729708d714e0444d8131ec494b61c6237afd876326af61a8a4bb9c2L66-L69
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 10, 2023
This for includes these two upstream PRs: micro/plugins#109 micro/plugins#110
rhafer
added a commit
to rhafer/reva
that referenced
this pull request
May 10, 2023
This bumps the go-micro/v4/store/redis fork to include these fixes: micro/plugins#109 micro/plugins#110 And removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to rhafer/reva
that referenced
this pull request
May 10, 2023
This bumps the go-micro/v4/store/redis fork to include these fixes: micro/plugins#109 micro/plugins#110 And removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to rhafer/reva
that referenced
this pull request
May 10, 2023
This bumps the go-micro/v4/store/redis fork to include these fixes: micro/plugins#109 micro/plugins#110 And removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to rhafer/reva
that referenced
this pull request
May 12, 2023
This bumps the go-micro/v4/store/redis fork to include these fixes: micro/plugins#109 micro/plugins#110 And removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to rhafer/reva
that referenced
this pull request
May 12, 2023
This bumps the go-micro/v4/store/redis to latest commit from the main branch to include these fixes: micro/plugins#109 micro/plugins#110 It also removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
May 12, 2023
This includes these two fixes: micro/plugins#109 micro/plugins#110
rhafer
added a commit
to cs3org/reva
that referenced
this pull request
May 12, 2023
This bumps the go-micro/v4/store/redis to latest commit from the main branch to include these fixes: micro/plugins#109 micro/plugins#110 It also removes the workaround of stripping the table prefixes in our code.
rhafer
added a commit
to owncloud/ocis
that referenced
this pull request
May 12, 2023
This includes these two fixes: micro/plugins#109 micro/plugins#110
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
May 12, 2023
This includes these two fixes: micro/plugins#109 micro/plugins#110
2403905
pushed a commit
to 2403905/reva
that referenced
this pull request
May 19, 2023
This bumps the go-micro/v4/store/redis to latest commit from the main branch to include these fixes: micro/plugins#109 micro/plugins#110 It also removes the workaround of stripping the table prefixes in our code.
fschade
pushed a commit
to owncloud/ocis
that referenced
this pull request
Jul 10, 2023
This includes these two fixes: micro/plugins#109 micro/plugins#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces mapping the
redis.Nilerror tostore.ErrNotFound