Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store/redis): use redis SCAN #97

Merged
merged 5 commits into from
Apr 5, 2023
Merged

feat(store/redis): use redis SCAN #97

merged 5 commits into from
Apr 5, 2023

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 23, 2023

redis KEYS may block other requests. This PR changes List and Read to SCAN and implements prefix and suffix

  • do not fail when redis cannot be initialized
  • make redis store use SCAN to list keys, with prefix and suffix
  • read using SCAN with prefix and suffix

@butonic
do not fail when redis cannot be initialized
9870aad 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make redis store use SCAN to list keys
4b583e0 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
read using scan with prefix and suffix
459bd05 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic mentioned this pull request Mar 23, 2023
Closed
@butonic
linter does not want to cuddle
76879d9 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
only run redis unit test when REDIS_URL is configured
784fca8 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@Davincible
Copy link
Contributor

Thanks for the contribution, looks good

@Davincible Davincible changed the title use redis SCAN feat(store/redis): use redis SCAN Apr 5, 2023
@Davincible Davincible merged commit efd9191 into micro:main Apr 5, 2023
@Excds Excds mentioned this pull request May 8, 2023
Closed
@butonic butonic mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davincible Davincible Davincible approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @Davincible