V1 settings middleware #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
npm run lintto find errors in code syntax/formatnpm run lint:fixto fix all auto-fixable errors in source code and auto-format with prettierWhat does this PR do
Fixes #538
This PR is uses the source code from PR #539 as a basis to implementing the same feature on v1 of the implementation. The base PR was authored by @dave-ok .
Description of Task to be completed
Please see this section on PR #539
In addition, the
mysqlclient library for node has been used to make a connection with the MicroAPI database.How should this be manually tested
None
Any background context you want to provide
Please see this section on PR #539
Questions
None