-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE YET change MIxS import to 6.2 #1386
base: main
Are you sure you want to change the base?
Conversation
turbomam
commented
Nov 20, 2023
- change nmdc-schema's MIxS import to GSC's 6.2 YAML #1368
Hi @pkalita-lbl and @mslarae13 This is a version of nmdc-schema that imports slots form GSC's MIxS 6.2, as opposed to the static, GSC v6.0-like https://github.com/microbiomedata/mixs/blob/main/model/schema/mixs.yaml I have extensive notes in the accompanying issue #1386 but they may not be crystal clear yet The thing I want to emphasize here is that I have removed all |
I took a look at the changes here and read through the comments in #1368. I'm not sure I follow every single detail, but that's probably okay. In broad strokes, the goals make sense to me. If there's something you want me to do re: the submission schema before this is merged and/or released, let me know. |
Overall, I'm on the same page as @pkalita-lbl . I understand the want and I support it! I think having this static MIxS file is a source of incompatibility and error. |
|
as opposed tom commenting out