Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE YET change MIxS import to 6.2 #1386

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

turbomam
Copy link
Member

@turbomam turbomam linked an issue Nov 20, 2023 that may be closed by this pull request
@turbomam
Copy link
Member Author

Hi @pkalita-lbl and @mslarae13

This is a version of nmdc-schema that imports slots form GSC's MIxS 6.2, as opposed to the static, GSC v6.0-like https://github.com/microbiomedata/mixs/blob/main/model/schema/mixs.yaml

I have extensive notes in the accompanying issue #1386 but they may not be crystal clear yet

The thing I want to emphasize here is that I have removed all yq customization of MIxS slots except for the ones that are used in MongoDB as of now. So that means some MIxS slots may be presented to submission-schema now in a slightly different way, so we may need to make minor changes to the sheets_and_friends configuration.

@turbomam turbomam changed the title 1368 change mixs import to 62 1368 change mixs import to 6.2 Nov 20, 2023
@turbomam turbomam marked this pull request as draft November 20, 2023 13:23
@turbomam turbomam changed the title 1368 change mixs import to 6.2 DO NOT MERGE YET change MIxS import to 6.2 Nov 20, 2023
@pkalita-lbl
Copy link
Collaborator

I took a look at the changes here and read through the comments in #1368. I'm not sure I follow every single detail, but that's probably okay. In broad strokes, the goals make sense to me. If there's something you want me to do re: the submission schema before this is merged and/or released, let me know.

@mslarae13
Copy link
Contributor

Overall, I'm on the same page as @pkalita-lbl . I understand the want and I support it! I think having this static MIxS file is a source of incompatibility and error.

@turbomam turbomam marked this pull request as ready for review July 17, 2024 18:45
@turbomam turbomam changed the base branch from main-old to main July 17, 2024 18:46
@turbomam turbomam marked this pull request as draft July 17, 2024 18:47
Copy link

github-actions bot commented Jul 17, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-1386/
on branch gh-pages at 2024-07-18 16:47 UTC

@turbomam turbomam marked this pull request as ready for review July 17, 2024 19:35
@turbomam turbomam marked this pull request as draft July 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change nmdc-schema's MIxS import to GSC's 6.2 YAML
4 participants