Fix model number error for Windows OS #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-robert
commented
Nov 29, 2024
microbit-matt-hillsdon
requested review from
microbit-grace and
microbit-matt-hillsdon
Deploying microbit-connection with
|
| Latest commit: |
e21e234
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d301b30.microbit-connection.pages.dev |
| Branch Preview URL: | https://model-number.microbit-connection.pages.dev |
microbit-matt-hillsdon
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think reconnecting via the UI used to call the reconnect method in the device wrapper where we wait for the Windows Bluetooth disconnection before reconnecting. This reconnect method is now only called internally for automatic reconnection attempts.
This means, that on Windows, the user can click disconnect, then connect/reconnect quickly which results in the model number error. This fix prevents that from happening.
I could not reproduce the model number error following these intructions #39. This could be a separate or related issue.