Skip to content

Conversation

@microbit-robert
Copy link
Contributor

@microbit-robert microbit-robert commented Dec 23, 2024

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying microbit-connection with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12890f3
Status: ✅  Deploy successful!
Preview URL: https://d7420e6b.microbit-connection.pages.dev
Branch Preview URL: https://magnetometer.microbit-connection.pages.dev

View logs

@microbit-robert microbit-robert marked this pull request as ready for review December 23, 2024 15:32
@microbit-robert microbit-robert requested a review from a team December 23, 2024 15:32
Copy link
Contributor

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Tried out the magnetometer service using a hex provided by Rob that has magnetometer service initiated.

Comment on lines +110 to +111
// Documentation for allowed values looks wrong.
// https://lancaster-university.github.io/microbit-docs/ble/profile/#about-the-magnetometer-service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, interesting that setting the values to the documented values don't seem to work.

@microbit-robert microbit-robert changed the title Add basic magnetometer service Add magnetometer service Jan 2, 2025
@microbit-robert microbit-robert merged commit bb2eb6b into main Jan 2, 2025
2 checks passed
@microbit-robert microbit-robert deleted the magnetometer branch January 2, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants