Don't dispose a serial session if it's not open #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the number of serial listeners and only start and stop serial when required.
Deploying microbit-connection with
|
| Latest commit: |
26872d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a70332c5.microbit-connection.pages.dev |
| Branch Preview URL: | https://ignore-delegate-alt.microbit-connection.pages.dev |
microbit-grace
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Thanks LGTM
Tested it locally for CreateAI radio connection and tried flashing the remote and link micro:bits - both works well.
For the Python Editor, this issue is still fixed, though unplugging the micro:bit and flashing again seems to cause a long pause before serial output is shown. But as discussed, this is an existing issue
|
Looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the number of serial listeners and only start and stop serial when required.
Alternative to #64