Tweak flash interface #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the implementation but not the types I've left open the possibility of passing a MemoryMap so I can experiement with it as an option. This means we have a hard dependency on the intel hex library but I think we should either stick with that or have a slimline version.
Something is still awry here but I'm not sure what.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a mistake where we padded with 0 not 0xff.
On the implementation but not the types I've left open the possibility of passing a MemoryMap so I can experiment with it as an option.
MemoryMap imports remain a bit of a disaster but one to investigate further another day.
For the Python Editor this will mean that we always return a hex from the file system and then parse it for the partial flashing case. But that seems a much more reasonable API and the conversion should be quick enough. If we care for perf then we can work towards using the MemoryMap built by microbit-fs directly. There's no reason to be going via padded bytes as that drops the UICR data which it would be better to flash.