Theme package #336
Merged
Theme package #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-matt-hillsdon
commented
Oct 3, 2024
microbit-matt-hillsdon
commented
- Separate out micro:bit branding for clarity if folks deploy alternative versions
- Parameterise the app name
- Don't pull purple in just for links
|
Preview build will be at |
|
Known changes:
|
| @@ -1,6 +1,12 @@ | |||
| /** | |||
There was a problem hiding this comment.
This now matches the Open Source Python one (Helvetica Now is our commercial font on .org).
| welcomeVideoYouTubeId: "mREwMW69qKc", | ||
| appNameFull: "ml-trainer", | ||
| appNameShort: "ml-trainer", | ||
| AppLogo: (props: BoxProps) => { |
There was a problem hiding this comment.
Will discuss what placeholder is suitable with Jonny but no need to block on that.
Will align with repo name change soon.
…iner into theme-package
|
|
||
| const Alert: StyleConfig = { | ||
| variants: { | ||
| // TODO: reconsider this theme customisation |
There was a problem hiding this comment.
Is there something to reconsider?
There was a problem hiding this comment.
It seems odd to pull in teal but green on green isn't great so I've left it pending better ideas.
|
I'm going to go ahead and merge this now as it's going to be a painful source of conflicts otherwise. I'll update current PRs as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.