Skip to content

Fix switch tabs logic when radio bridge connection is disconnected #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Fix switch tabs logic when radio bridge connection is disconnected #341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1f4f18
Fix switch tabs logic for radio bridge connection
microbit-grace Oct 3, 2024
dd909bd
Merge branch 'react' of https://github.com/microbit-foundation/ml-tra…
microbit-grace Oct 4, 2024
2870433
Only keep up to date with connection status when browser tab is visible
microbit-grace Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/connect-status-hooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,12 @@ export const useConnectStatusUpdater = (
useState<boolean>(true);

useEffect(() => {
if (!isBrowserTabVisible && currConnType === "radio") {
// Show reconnecting when user hides browser tab for radio bridge connection
if (
!isBrowserTabVisible &&
currConnType === "radio" &&
connectionStatus === ConnectionStatus.Connected
) {
// Show reconnecting when user hides browser tab and is radio connected
setConnectionStatus(ConnectionStatus.ReconnectingAutomatically);
return;
}
Expand All @@ -131,7 +135,7 @@ export const useConnectStatusUpdater = (
setOnFirstConnectAttempt,
});
prevDeviceStatus.current = deviceStatus;
if (nextState) {
if (nextState && isBrowserTabVisible) {
handleStatus && handleStatus(nextState.status, nextState.flowType);
setConnectionStatus(nextState.status);
}
Expand Down
Loading