Handling tab visibility in getNextConnectionState

[microbit-grace]

• Handle tab visibility in getNextConnectionState as Rob suggested and add logic to show radio bridge error dialog if tab is visible, otherwise show connection status as reconnecting automatically
• Consider failing twice state as a connection start over and reset onFirstConnectAttempt and hasAttemptedReconnect

Private link to related issues:

• https://microbit-global.monday.com/boards/1550536443/pulses/1687691747
• https://microbit-global.monday.com/boards/1550536443/pulses/1696956864

[github-actions]

Preview build will be at
https://review-createai.microbit.org/fix-conn-status/

[microbit-matt-hillsdon]

I find this change hard to understand. Can you write a bit more explanation (on the PR in the first instance) ?

Do you think there's something different we could do in the connection library to simplify the code here / remove special cases?

[microbit-grace]

I find this change hard to understand. Can you write a bit more explanation (on the PR in the first instance) ?

Have added more explanation in the PR description. Hope that helps!

Do you think there's something different we could do in the connection library to simplify the code here / remove special cases?

Possibly? One way I can think of is if we introduced new connection status(es) that can distinguish between reason behind different disconnected states maybe (e.g. disconnected explicitly by user, connection loss, connect error, tab switching)? But on the other hand, I'm not sure if the connection library should be aware of these reasons if it was a general-use library

[microbit-grace]

Possibly can handle another tab visibility issue as well (private link to issue: https://microbit-global.monday.com/boards/1550536443/pulses/1696956864)

[microbit-grace]

Letting hasStartedOver logic handle the resetting of this instead for when reconnect fail twice. Also, important to setOnFirstConnectAttempt(true) for attempts after reconnect fail twice to avoid reconnect fail twice error dialog from being triggered again in subsequent start over connection attempt errors

[microbit-matt-hillsdon]

Thanks for working through this one.