reduced implied urls (fixes #117), added tests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -347,21 +349,18 @@ def parse_props(el): | |||
| # if this is not a property element, but it is a h-* microformat, | |||
| # add it to our list of children | |||
| if not is_property_el and root_class_names: | |||
There was a problem hiding this comment.
shouldn't this add h to the parsed_type_aggregation?
There was a problem hiding this comment.
This should be covered in Line 258. Since it doesn't matter if it is a child or a nested property, I add it there already. Unless I missed a code path?
There was a problem hiding this comment.
aah yes I missed that change
| @@ -199,7 +199,7 @@ def handle_microformat(root_class_names, el, value_property=None, | |||
| if x is not None: | |||
| properties["photo"] = [x] | |||
|
|
|||
There was a problem hiding this comment.
might be good to add a comment like in the implied name thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implied name was tracked in a bool before, I now track the types of properties encountered in a set and check for names and url, prepared for any other implied properties being restricted.