Merge pull request #728 from microlinkhq/video

test: skip vimeo
microlinkhq · Oct 21, 2024 · 79bc161 · 79bc161
2 parents 50363a6 + 48d1989
commit 79bc161
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/packages/metascraper-manifest/test/snapshots/index.js.md b/packages/metascraper-manifest/test/snapshots/index.js.md
@@ -77,7 +77,7 @@ Generated by [AVA](https://avajs.dev).
     {
       description: null,
       lang: null,
-      logo: 'https://www.gstatic.com/youtube/img/branding/favicon/favicon_192x192_v2.png',
+      logo: 'https://www.gstatic.com/youtube/img/branding/favicon/favicon_192x192.png',
       publisher: 'YouTube',
     }
 

diff --git a/packages/metascraper-manifest/test/snapshots/index.js.snap b/packages/metascraper-manifest/test/snapshots/index.js.snap
diff --git a/packages/metascraper-media-provider/test/fixtures/generate.js b/packages/metascraper-media-provider/test/fixtures/generate.js
@@ -4,7 +4,7 @@ const youtubedl = require('youtube-dl-exec')
 const path = require('path')
 const fs = require('fs/promises')
 
-const { getFlags } = require('../../src/get-media/provider/generic')
+const { getFlags } = require('../../src/get-media')
 
 let [, , url, filename] = process.argv
 

diff --git a/packages/metascraper-media-provider/test/video/index.js b/packages/metascraper-media-provider/test/video/index.js
@@ -9,13 +9,14 @@ const { metascraper } = require('../helpers')
 const isCI = !!process.env.CI
 
 ;[
+  // TODO: vimeo is not exposing an HTTP endpoint URL for the video
   // TODO: uncomment when the issue is resolved
   // https://github.com/ytdl-org/youtube-dl/issues/29205
   // 'https://vimeo.com/channels/staffpicks/287117046',
   // 'https://vimeo.com/showcase/3717822',
-  'https://vimeo.com/443437002'
+  // 'https://vimeo.com/443437002'
 ].forEach(url => {
-  ;(isCI ? test.skip : test)(url, async t => {
+  test.skip(url, async t => {
     const metadata = await metascraper({ url })
     debug(metadata.video)
     t.is(extension(metadata.video), 'mp4')
@@ -29,7 +30,7 @@ const isCI = !!process.env.CI
   })
 })
 ;['https://www.instagram.com/p/BmYooZbhCfJ'].forEach(url => {
-  ;(isCI ? test.skip : test)(url, async t => {
+  test.skip(url, async t => {
     const metadata = await metascraper({ url })
     debug(metadata.video)
     t.true(isUrl(metadata.video))