Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump react-textarea-autosize dep to allow react v19 update #57

Conversation

andreykovalenko
Copy link

@andreykovalenko andreykovalenko commented Feb 3, 2025

Yarn reports that React 19 doesn't have a dependency resolution with the 8.3.2 version of react-textarea-autosize package.

Version 8.5.7 now lists React 19 as a peerDependency making this problem fixed.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:36pm

@Kikobeats
Copy link
Member

Thanks!

@Kikobeats Kikobeats merged commit 6c510f8 into microlinkhq:master Feb 3, 2025
2 checks passed
@andreykovalenko
Copy link
Author

@Kikobeats thank you for merging it, when do you plan to release a new NPM version?

@Kikobeats
Copy link
Member

@andreykovalenko unfortunately tests are not passing green anymore, can you take a look?
https://github.com/microlinkhq/react-json-view/actions/runs/13119751301/job/36603180489

@andreykovalenko
Copy link
Author

@andreykovalenko unfortunately tests are not passing green anymore, can you take a look? https://github.com/microlinkhq/react-json-view/actions/runs/13119751301/job/36603180489

This change is not the cause of the CI failures. It has been broken due to your dev tools not being compatible with the NodeJs v22 since the NodeJs LTS tag was updated from v18 to v22. Anyway you have two options:

  1. A simple one is to set CI to use NodeJs v18. I've made the change before but you rejected it.
  2. A complex one - update dev dependencies and Webpack to use NodeJs v22. Sorry I don't have capacity to do it right now.

When you have CI set to use the LTS version instead of the specific version, it will break the next time the NodeJs LTS tag is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants