Merge pull request #2 from Kikobeats/windows

test: better error assertion
microlinkhq · Dec 12, 2023 · 9a04a05 · 9a04a05
2 parents f6ecb38 + ab077a9
commit 9a04a05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -53,7 +53,7 @@ jobs:
       - name: Test
         run: pnpm test
       - name: Report
-        run: mkdir -p coverage && npx c8 report --reporter=text-lcov > coverage/lcov.info
+        run: npx c8 report --reporter=text-lcov > coverage/lcov.info
       - name: Coverage
         uses: coverallsapp/github-action@main
         with:

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -29,7 +29,7 @@ jobs:
       - name: Test
         run: pnpm test
       - name: Report
-        run: mkdir -p coverage && npx c8 report --reporter=text-lcov > coverage/lcov.info
+        run: npx c8 report --reporter=text-lcov > coverage/lcov.info
       - name: Coverage
         uses: coverallsapp/github-action@main
         with:
@@ -55,7 +55,7 @@ jobs:
       - name: Test
         run: pnpm test
       - name: Report
-        run: mkdir -p coverage && npx c8 report --reporter=text-lcov > coverage/lcov.info
+        run: npx c8 report --reporter=text-lcov > coverage/lcov.info
       - name: Coverage
         uses: coverallsapp/github-action@main
         with:

diff --git a/test/index.js b/test/index.js
@@ -5,11 +5,11 @@ const test = require('ava')
 const $ = require('..').extend({ shell: true })
 
 test('meaningful errors', async t => {
-  const error = await $('node -e \'require("notfound")\'').catch(error => error)
+  const error = await $('node --foo').catch(error => error)
   t.is(error.name, 'ChildProcessError')
-  t.is(error.stderr.includes("Cannot find module 'notfound'"), true)
+  t.is(error.stderr, 'node: bad option: --foo')
   t.is(error.stdout, '')
-  t.is(error.exitCode, 1)
+  t.is(error.exitCode, 9)
   t.is(error.signalCode, null)
   t.is(error.killed, false)
 })
@@ -31,7 +31,7 @@ test.serial('last break line is removed', async t => {
 })
 
 test('run a file', async t => {
-  const { stdout } = await $('node -e \'console.log("hello world")\'')
+  const { stdout } = await $('node -p "\'hello world\'"')
   t.is(stdout, 'hello world')
 })