-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce maxLength default to 10,000 and revert maxSymbols change #40
Merged
jonschlinkert
merged 3 commits into
micromatch:master
from
AaronMoat:SNYK-JS-BRACES-6838727
May 21, 2024
Merged
Reduce maxLength default to 10,000 and revert maxSymbols change #40
jonschlinkert
merged 3 commits into
micromatch:master
from
AaronMoat:SNYK-JS-BRACES-6838727
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxSymbols
change
maxSymbols
change
thanks for the merge, however I still see the issue still open, how should we resolve it? |
@thanhnhan2tn do you mean the flagged security vulnerability in Snyk/Blackduck/et al? You'll need to talk to your security vendor and have them fix it on their end, as maintainers of OSS software cannot do that for you |
Sent from Mail app for iOS
Thursday, January 16, 2025 at 1:09 AM -06:00 from ***@***.*** ***@***.***>:
…
@Scutua approved this pull request.
—
Reply to this email directly, view it on GitHub , or unsubscribe .
You are receiving this because you are subscribed to this thread. Message ID: <micromatch/braces/pull/40/review/2554956983 @ github . com>
|
This was referenced Jan 21, 2025
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loved this comment @jonschlinkert : #37 (comment)
I have a bias for explicit configuration closer to the process - rather than an env var. Are we happy with simply lowering it?