Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document when LatencyUtils and HdrHistogram dependencies are needed #240

Closed
shakuzen opened this issue Aug 2, 2022 · 0 comments · Fixed by #241
Closed

Document when LatencyUtils and HdrHistogram dependencies are needed #240

shakuzen opened this issue Aug 2, 2022 · 0 comments · Fixed by #241

Comments

@shakuzen
Copy link
Member

shakuzen commented Aug 2, 2022

If you are not configuring a pause detector, you can exclude the LatencyUtils dependency.
If you are not configuring client-side percentiles, you can exclude the HdrHistogram dependency.

Originally posted by @shakuzen in micrometer-metrics/micrometer#1599 (comment)
@shakuzen shakuzen mentioned this issue Aug 3, 2022
Merged
shakuzen added a commit that referenced this issue Aug 4, 2022
@shakuzen
Document when dependencies are needed (#241)
b745539 
While we declare dependencies in micrometer-core's published POM, we didn't explain them in documentation. This adds that explanation, especially given we have recently made changes to verify that these dependencies are not needed at compile time and are only needed at runtime if the corresponding feature is used.

Closes gh-240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document runtime dependencies micrometer-metrics/micrometer-docs
1 participant
@shakuzen