Skip to content

Commit

Permalink
Declare HdrHistogram as a runtime dependency (#3263)
Browse files Browse the repository at this point in the history
HdrHistogram is not exposed in API users should be compiling against. It is an implementation detail of client-side percentiles. The scope of the dependency can be changed accordingly. If client-side percentiles are used, HdrHistogram is needed at runtime, as declared with this change. If client-side percentiles are not used, HdrHistogram can be excluded from the runtime classpath without issue.
  • Loading branch information
shakuzen authored Aug 3, 2022
1 parent 539c4fe commit 2c39c9f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions micrometer-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ dependencies {
api project(":micrometer-commons")
api project(":micrometer-observation")

// TODO(anuraaga): HdrHistogram is exposed in the micrometer API but probably shouldn't be
api 'org.hdrhistogram:HdrHistogram'
implementation 'org.hdrhistogram:HdrHistogram'
implementation('org.latencyutils:LatencyUtils') {
exclude group: 'org.hdrhistogram', module: 'HdrHistogram'
}
Expand Down

0 comments on commit 2c39c9f

Please sign in to comment.