Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "host" tag to JettyClientMetrics #2054

Closed
dragneelfps opened this issue May 4, 2020 · 3 comments · Fixed by #2202
Closed

Add "host" tag to JettyClientMetrics #2054

dragneelfps opened this issue May 4, 2020 · 3 comments · Fixed by #2202
Labels
enhancement A general enhancement
Milestone
1.7.0-RC1

Comments

@dragneelfps
Copy link

Having bult in support for "host" tag found in other metric clients such as OkHttp3 will be very helpful.

P.S- I can work on this if it is approved.
@dragneelfps
Copy link
Author

Adding onto this, can we a set of pre-defined tags for diffirenet http client micrometer implementations, so that we have a clear, unamibigous taglist.

@jkschneider
Copy link
Contributor

jkschneider commented May 6, 2020 •
edited
Loading

@dragneelfps Yes, this seems like a good improvement that we'd happily take a PR for at either or both levels (just improving JettyClientMetrics and trying to generalize further).

@jkschneider jkschneider added enhancement A general enhancement help wanted An issue that a contributor can help us with labels May 6, 2020
dennysfredericci pushed a commit to dennysfredericci/micrometer that referenced this issue Jul 22, 2020
Add "host" tag to JettyClientMetrics.(micrometer-metrics#2054)
28e86a5
@dennysfredericci
Copy link
Contributor

Hi @dragneelfps 😊

Thank you for your suggestion, I just create a PR to add the host.

@shakuzen shakuzen added this to the 1.7.0-RC1 milestone Apr 13, 2021
@shakuzen shakuzen removed the help wanted An issue that a contributor can help us with label Apr 13, 2021
@shakuzen shakuzen mentioned this issue Apr 13, 2021
Merged
shakuzen pushed a commit that referenced this issue Apr 13, 2021
@dennysfredericci
Add "host" tag to JettyClientMetrics (#2202)
7f0b24c 
Resolves gh-2054

Co-authored-by: Dennys Fredericci <dennys.fredericci@kbc.be>
@shakuzen shakuzen changed the title Add "host" tag to JettyClientMetrics. Add "host" tag to JettyClientMetrics Apr 13, 2021
izeye added a commit to izeye/micrometer that referenced this issue Apr 14, 2021
@izeye
Add Javadoc since to JettyClientTags.host()
7756993 
See micrometer-metricsgh-2054
@izeye izeye mentioned this issue Apr 14, 2021
Merged
shakuzen pushed a commit that referenced this issue Apr 14, 2021
@izeye
Add Javadoc since to JettyClientTags.host() (#2572)
d402940 
See gh-2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.7.0-RC1
Development

Successfully merging a pull request may close this issue.

Add "host" tag to JettyClientMetrics dennysfredericci/micrometer
4 participants
@dennysfredericci @jkschneider @shakuzen @dragneelfps