Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Caffeine #2465

Closed
jonatan-ivanov opened this issue Feb 23, 2021 · 3 comments · Fixed by #2478
Closed

Update Caffeine #2465

jonatan-ivanov opened this issue Feb 23, 2021 · 3 comments · Fixed by #2478

Comments

@jonatan-ivanov
Copy link
Member

Caffeine 3.0.0 has been released recently (https://search.maven.org/artifact/com.github.ben-manes.caffeine/caffeine) with some breaking changes, micrometer supports 2.x (766fa07).
@ben-manes
Copy link

ben-manes commented Feb 25, 2021 •
edited
Loading

I believe the only change that impacts this project is StatsCounter. This can be made backwards compatible by retaining the deprecated recordEviction() method and removing the @Override. It should cross compile.

micrometer/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/CaffeineStatsCounter.java

Lines 147 to 150 in c3e2b08

@SuppressWarnings("deprecation")
@Override
public void recordEviction() {
}

izeye added a commit to izeye/micrometer that referenced this issue Feb 25, 2021
@izeye
Use latest.release for Caffeine
54928e5 
This commit also updates CaffeineStatsCounter to support Caffeine 3+ while maintaining Caffeine 2+ support.

Closes micrometer-metricsgh-2465
@izeye izeye mentioned this issue Feb 25, 2021
Closed
@izeye
Copy link
Contributor

izeye commented Feb 25, 2021

@ben-manes Thanks! I created #2476 to try to resolve this.

izeye added a commit to izeye/micrometer that referenced this issue Feb 26, 2021
@izeye
Support Caffeine 3
3e3f12e 
See micrometer-metricsgh-2465
See micrometer-metricsgh-2476
@izeye izeye mentioned this issue Feb 26, 2021
Merged
jonatan-ivanov pushed a commit that referenced this issue Feb 26, 2021
@izeye
Support Caffeine 3 (#2478)
e7d1b28 
See gh-2465
See gh-2476
@jonatan-ivanov jonatan-ivanov linked a pull request Feb 26, 2021 that will close this issue
Support Caffeine 3 #2478
Merged
@jonatan-ivanov
Copy link
Member Author

Fixed in #2478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Caffeine 3 izeye/micrometer
Use latest.release for Caffeine izeye/micrometer
3 participants
@ben-manes @izeye @jonatan-ivanov