Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientTimingInstrumentationVerificationTests cannot be implemented #3308

Closed
marcingrzejszczak opened this issue Jul 22, 2022 · 2 comments
Closed

HttpClientTimingInstrumentationVerificationTests cannot be implemented #3308

marcingrzejszczak opened this issue Jul 22, 2022 · 2 comments
Labels
bug A general bug module: micrometer-test An issue that is related to our TCK
Milestone
1.8.9

Comments

@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented Jul 22, 2022 •
edited by shakuzen
Loading

The HttpMethod enum is currently package private so the test can't be extended
@marcingrzejszczak marcingrzejszczak added bug A general bug module: micrometer-test An issue that is related to our TCK labels Jul 22, 2022
@marcingrzejszczak marcingrzejszczak added this to the 1.10.0-M4 milestone Jul 22, 2022
@shakuzen shakuzen changed the title HttpClientTimingInstrumentationVerificationTests should open HTTPMethod enum HttpClientTimingInstrumentationVerificationTests cannot be implemented Jul 22, 2022
@shakuzen
Copy link
Member

shakuzen commented Jul 22, 2022 •
edited
Loading

The abstract method sendHttpRequest also needs to be opened to be overridden in subclasses.

@shakuzen shakuzen reopened this Jul 22, 2022
@shakuzen
Copy link
Member

This should be backported to 1.8.x

@shakuzen shakuzen reopened this Jul 22, 2022
@shakuzen shakuzen modified the milestones: 1.10.0-M4, 1.8.9 Jul 22, 2022
shakuzen added a commit that referenced this issue Jul 22, 2022
@shakuzen
Make sendHttpRequest protected
2a7b1dc 
It could not be implemented by classes outside the same package previously because it was package-private.

Closes gh-3308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug module: micrometer-test An issue that is related to our TCK
Projects
None yet
Milestone
1.8.9
Development

No branches or pull requests
2 participants
@marcingrzejszczak @shakuzen