Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Relic module fails on the module path #3412

Closed
shakuzen opened this issue Sep 14, 2022 · 1 comment
Closed

New Relic module fails on the module path #3412

shakuzen opened this issue Sep 14, 2022 · 1 comment
Labels
bug A general bug registry: new relic A New Relic Registry related issue
Milestone
1.8.11

Comments

@shakuzen
Copy link
Member

This is failing for me because:

Error occurred during initialization of boot layer
java.lang.module.FindException: Unable to derive module descriptor for /.../micrometer/implementations/micrometer-registry-new-relic/build/libs/micrometer-registry-new-relic-1.10.0-SNAPSHOT.jar
Caused by: java.lang.module.FindException: Automatic-Module-Name: micrometer.registry.new.relic: Invalid module name: 'new' is not a Java identifier

Originally posted by @jonatan-ivanov in #3411 (comment)
@shakuzen shakuzen added bug A general bug registry: new relic A New Relic Registry related issue labels Sep 14, 2022
@shakuzen shakuzen added this to the 1.8.11 milestone Sep 14, 2022
@shakuzen
Copy link
Member Author

We should change the Automatic-Module-Name entry in the MANIFEST.MF file from micrometer.registry.new.relic to micrometer.registry.newrelic. This would be a breaking change, but no one has ever been able to use the old automatic module name due to the above mentioned error.

@shakuzen shakuzen mentioned this issue Sep 14, 2022
Merged
3 tasks
shakuzen pushed a commit that referenced this issue Sep 14, 2022
@marcingrzejszczak
Automated java module checking (#3411)
50f07d9 
Adds a task called `testModules` that calls `java --list-modules` on each JAR file built to check that its modules can be listed. We have had issues in the past that went unnoticed, and this is one of the easiest ways to do a sanity check that a JAR will work on the module path. See, for example, gh-3398 and gh-3412, which would have been caught by this check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug registry: new relic A New Relic Registry related issue
Projects
None yet
Milestone
1.8.11
Development

No branches or pull requests
1 participant
@shakuzen