-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Apache HttpComponents instrumentation to support the exception
tag.
#3812
Labels
superseded
An issue that has been superseded by another
Comments
shakuzen
added
enhancement
A general enhancement
help wanted
An issue that a contributor can help us with
module: micrometer-core
An issue that is related to our core module
and removed
waiting-for-triage
labels
May 8, 2023
shakuzen
added
the
instrumentation
An issue that is related to instrumenting a component
label
May 8, 2023
This seems to have been covered through #3800 already. |
Yes, closed with #3800 for http client 5. |
jonatan-ivanov
added
superseded
An issue that has been superseded by another
and removed
enhancement
A general enhancement
help wanted
An issue that a contributor can help us with
module: micrometer-core
An issue that is related to our core module
instrumentation
An issue that is related to instrumenting a component
labels
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe the feature request.
Enhance Apache HttpComponents instrumentation to support the
exception
tag.Rationale
Most if not all the other http client / server based instrumentations support an
exception
Tag. For the sake of consistency, enable to HttpComponents instrumentation to support theexception
tag.Additional context
I'm happy to contribute. A PR would be blocked by #3800 since the HttpAsyncClient currently does not meter errors / IOExceptions.
Relates to #3729
The text was updated successfully, but these errors were encountered: