Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently add outcome tag to all HTTP client instrumentation #3729

Closed
kubamarchwicki opened this issue Mar 31, 2023 · 3 comments · Fixed by #3732
Closed

Consistently add outcome tag to all HTTP client instrumentation #3729

kubamarchwicki opened this issue Mar 31, 2023 · 3 comments · Fixed by #3732
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Milestone
1.11.0-RC1

Comments

@kubamarchwicki
Copy link
Contributor

kubamarchwicki commented Mar 31, 2023 •
edited
Loading

To enhance metrics filtering, a grouping outcome tag would be helpful in http_client_requests, similar to the outcome tag in the http_server_requests.

For less matured metrics systems (like CloudWatch) it's impossible to filter by patterns, and having a similar grouping in HTTP client and server metrics would be very helpful.

PS. I couldn't find any issue related to this one, so I created a new one. Please let me know if I've overlooked something
PS2. If such a tag makes sense, I'm happy to raise a PR and work on that.
@shakuzen
Copy link
Member

Thanks for opening the issue. Which HTTP client instrumentation are you using? We already have an outcome tag on some of them.

@shakuzen shakuzen added waiting for feedback We need additional information before we can continue and removed waiting-for-triage labels Mar 31, 2023
@kubamarchwicki
Copy link
Contributor Author

Thank you for the swift answer. I was instrumenting JDK11 HttpClient
I can see the Outcome::forStatus is used a couple of times, but primarily for server-side requests (and for JettyClient).

I'll happily raise a couple of PRs for different clients to align it

@shakuzen
Copy link
Member

Thank you for the offer to help. We'd be happy to review pull requests for this.

@shakuzen shakuzen added enhancement A general enhancement module: micrometer-core An issue that is related to our core module help wanted An issue that a contributor can help us with and removed waiting for feedback We need additional information before we can continue labels Mar 31, 2023
@shakuzen shakuzen added this to the 1.x milestone Mar 31, 2023
@kubamarchwicki kubamarchwicki mentioned this issue Mar 31, 2023
Merged
@shakuzen shakuzen modified the milestones: 1.x, 1.11.0-RC1 Apr 4, 2023
@shakuzen shakuzen removed the help wanted An issue that a contributor can help us with label Apr 4, 2023
@shakuzen shakuzen changed the title An outcome tag in the http_client_requests Consistently add outcome tag to HTTP client instrumentation Apr 4, 2023
@izeye izeye mentioned this issue Apr 7, 2023
Merged
izeye added a commit to izeye/micrometer that referenced this issue Apr 7, 2023
@izeye
Add Javadoc since for outcome key name enum values
ab29387 
See micrometer-metricsgh-3729
shakuzen pushed a commit that referenced this issue Apr 10, 2023
@izeye
Add Javadoc since for outcome key name enum values (#3748)
3c6e834 
See gh-3729
@shakuzen shakuzen changed the title Consistently add outcome tag to HTTP client instrumentation Consistently add outcome tag to all HTTP client instrumentation Apr 17, 2023
@cachescrubber cachescrubber mentioned this issue May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.11.0-RC1
Development

Successfully merging a pull request may close this issue.

Add outcome tag to HttpClient metrics kubamarchwicki/micrometer
2 participants
@kubamarchwicki @shakuzen