Add outcome tag to HttpClient metrics #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Really great work aligning all of these. Thank you so much for that. I think we can also add an outcome to the tags asserted in HttpClientTimingInstrumentationVerificationTests since it should be on all implementations now. Would you update that? Then I think it's ready to merge. Thanks again.
|
Good catch. Forgot about it. Added in acebcb0 |
shakuzen
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3729
Aligning tags between
http_client_requestsmetrics. A grouping outcome tag was added to all http client binders - similar to the outcome tag inJettyClientand thehttp_server_requests.