Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicrometerHttpRequestExecutor fails to instrument with Apache HC 5.4 #5575

Closed
shakuzen opened this issue Oct 9, 2024 · 1 comment
Closed

MicrometerHttpRequestExecutor fails to instrument with Apache HC 5.4 #5575

shakuzen opened this issue Oct 9, 2024 · 1 comment
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Milestone
1.12.11

Comments

@shakuzen
Copy link
Member

shakuzen commented Oct 9, 2024

Our implementation overrode one of the two execute methods from HttpRequestExecutor. From Apache HC 5.4, it seems the other is the one that gets called, while the default implementation of the one we override delegates to the other. We can make our implementation more robust by overriding both and delegating one to the other similarly. This was discovered in failed tests for the pull request to upgrade to Apache HC 5.4 #5525
@shakuzen shakuzen added bug A general bug module: micrometer-core An issue that is related to our core module instrumentation An issue that is related to instrumenting a component labels Oct 9, 2024
@shakuzen shakuzen added this to the 1.12.11 milestone Oct 9, 2024
@shakuzen shakuzen mentioned this issue Oct 9, 2024
Merged
@flozano
Copy link

flozano commented Oct 15, 2024 •
edited
Loading

Moved to separate issue as it seems a separate bug/change (#5593)

@flozano flozano mentioned this issue Oct 15, 2024
Closed
@yeikel yeikel mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.12.11
Development

No branches or pull requests
2 participants
@flozano @shakuzen