Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicrometerHttpRequestExecutor bad tag values in 1.13.6 / httpclient 5.4 async #5593

Closed
flozano opened this issue Oct 15, 2024 · 1 comment
Closed
Labels
invalid An issue that we don't feel is valid

Comments

@flozano
Copy link

flozano commented Oct 15, 2024

After upgrading to 1.13.6 / HttpClient 5.4, with the fix of #5575, I get again the request metrics, but something has changed.

In the classic Http Client case, it works exactly as before.

In the async Http Client case, before Http client 5.4 I got:

httpcomponents_httpclient_request_seconds_sum{httpclient="hc5async",method="GET",outcome="CLIENT_ERROR",status="401",target_host="0.0.0.0",target_port="50964",target_scheme="http",uri="/"}

now I am getting:

httpcomponents_httpclient_request_seconds_sum{httpclient="hc5async",method="GET",outcome="CLIENT_ERROR",status="401",target_host="UNKNOWN",target_port="UNKNOWN",target_scheme="UNKNOWN",uri="/"}

is this expected?

@flozano flozano changed the title MicrometerHttpRequestExecutor bad tag values in 13.6 / httpclient 5.4 async MicrometerHttpRequestExecutor bad tag values in 1.13.6 / httpclient 5.4 async Oct 15, 2024
@flozano
Copy link
Author

flozano commented Oct 15, 2024

please ignore. async does not use this method obviously 🤦

@flozano flozano closed this as completed Oct 15, 2024
@jonatan-ivanov jonatan-ivanov closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@jonatan-ivanov jonatan-ivanov added invalid An issue that we don't feel is valid and removed waiting-for-triage labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants