Add implementation of Caffeine's StatsCounter #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-karp
force-pushed
the
caffeine-statscounter
branch
from
1a598c8
to
124de33
Compare
|
Fixed the checkstyle issue. |
|
@john-karp Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Feb 5, 2021
Note this commit removes the eviction metric without a removal cause as it seems to be a no-op. See micrometer-metricsgh-2163
jonatan-ivanov
added a commit
that referenced
this pull request
Feb 6, 2021
Polish CaffeineStatsCounter contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Caffeine metrics listener interface allows for more detailed metrics than the approach taken by the existing CaffeineCacheMetrics binder, which only has access to the values available through the Cache API.
Context here: ben-manes/caffeine#409 (comment)