Add getContextualName(Context c) on Observation.Convention #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change we can't provide a naming convention for objects that rely on contextual names e.g. all spans with this change we can provide a standard naming convention for objects that rely on contextual names for e.g. spans
marcingrzejszczak
force-pushed
the
contextualNameOnObservationConvention
branch
from
9dfb298 to
40e0b55
Compare
shakuzen
approved these changes
Jul 20, 2022
| @@ -939,6 +946,17 @@ interface KeyValuesConvention { | |||
| */ | |||
| String getName(); | |||
|
|
|||
| /** | |||
| * Allows to override the contextual name for an observation. The Observation will | |||
| * be renamed only when an explicit context was passed - if an implicit context is | |||
There was a problem hiding this comment.
I think the documentation about when the contextual name will be overridden might be better on Observation#createNotStarted since that is where the mentioned logic is. A user could use this method in other ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change we can't provide a naming convention for objects that rely on contextual names e.g. all spans
with this change we can provide a standard naming convention for objects that rely on contextual names for e.g. spans