Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly pin gradle-info-plugin to 11.4.1 #3441

Merged

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Sep 28, 2022

gradle-info-plugin 11.4.1 upgrade has been done in f5fa146 but reverted in af7fa7e.

This PR restores gradle-info-plugin 11.4.1 upgrade.

buildscript-gradle.lockfile used to be retained regardless of removal of dependency locks but has been removed in f2977bc. I'm not sure if it's intentional or accidental.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Sep 28, 2022

⚠️ 10 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@shakuzen
Copy link
Member

Thanks for catching this.

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented Sep 28, 2022

This happens because other Gradle plugins are bringing in the old version so when you upgrade the buildscript-gradle.lockfile, you can get the old version, I should have made this safer, I'm sorry. See, this: nebula-plugins/gradle-info-plugin#99 (comment).

Btw we have buildscript-gradle.lockfile for other branches and I think we should have it).
I asked for a fix again, hopefully we get one soon.

@izeye I have no idea how did you catch this but thank you very much!
Could you please propagate this back to 1.8.x and also update buildscript-gradle.lockfile there?

@jonatan-ivanov jonatan-ivanov added this to the 1.8.11 milestone Sep 28, 2022
@jonatan-ivanov jonatan-ivanov added bug A general bug build A change in our build-system dependency-upgrade A dependency upgrade and removed bug A general bug labels Sep 28, 2022
@jonatan-ivanov jonatan-ivanov changed the title Restore gradle-info-plugin 11.4.1 upgrade Properly pin gradle-info-plugin to 11.4.1 Sep 28, 2022
@izeye izeye closed this Sep 28, 2022
@izeye izeye force-pushed the gradle-info-plugin-11.4.1 branch from 1704091 to b18196a Compare September 28, 2022 23:35
@izeye izeye reopened this Sep 28, 2022
@izeye izeye changed the base branch from main to 1.8.x September 28, 2022 23:36
@izeye
Copy link
Contributor Author

izeye commented Sep 28, 2022

@jonatan-ivanov Sure, I changed the base branch to the 1.8.x branch.

@jonatan-ivanov jonatan-ivanov merged commit 31bbf48 into micrometer-metrics:1.8.x Sep 28, 2022
@jonatan-ivanov
Copy link
Member

Thank you very much!

@izeye izeye deleted the gradle-info-plugin-11.4.1 branch September 28, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build A change in our build-system dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants