Add supplier variant for Observation.Context.getOrDefault() #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param <T> value type | ||
| * @return object or default if not present | ||
| */ | ||
| <T> T getOrDefault(Object key, Supplier<T> defaultObjectSupplier); |
There was a problem hiding this comment.
I guess that should be a default method of we don't want to break current users (assuming that anyone has ever created their own implementation of ObservationRegistry)
There was a problem hiding this comment.
@marcingrzejszczak Thanks for the feedback! I updated this based on your feedback.
marcingrzejszczak
approved these changes
Mar 22, 2023
|
Ah, one more thing - can you please add a test for this? |
| * @param defaultObjectSupplier supplier for default object to return | ||
| * @param <T> value type | ||
| * @return object or default if not present | ||
| */ |
There was a problem hiding this comment.
Could you please add @since 1.11.0?
|
@marcingrzejszczak @jonatan-ivanov Thanks! I applied your reviews in e11b3bd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a supplier variant for
Observation.Context.getOrDefault()to avoid default object creation where unnecessary.