Reduces overall memory allocation in DynatraceExporterV2 while exporting #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@belks Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@belks Thank you for signing the Contributor License Agreement! |
belks
force-pushed
the
stbe/dynatrace_exporter_allocated_memory
branch
from
2492e56 to
ff9135a
Compare
shakuzen
added
registry: dynatrace
shakuzen
approved these changes
Apr 13, 2023
| @@ -139,9 +136,22 @@ public void export(List<Meter> meters) { | |||
| // Lines that are too long to be ingested into Dynatrace, as well as lines that | |||
| // contain NaN or Inf values are not returned from "toMetricLines", and are | |||
| // therefore dropped. | |||
There was a problem hiding this comment.
This comment should probably also be moved to where toMetricLines is being called.
There was a problem hiding this comment.
Done. Moved the comment closer to toMetricLines
pirgeo
approved these changes
Apr 13, 2023
belks
force-pushed
the
stbe/dynatrace_exporter_allocated_memory
branch
from
ff9135a to
3deb668
Compare
belks
force-pushed
the
stbe/dynatrace_exporter_allocated_memory
branch
from
3deb668 to
978ed02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In applications with a lot of metrics the Dynatrace exporter collects all lines to be exported in one list before sending them in batches. This allocates quite a lot of unnecessary memory.
This PR changes this behavior so that batches are sent immediately and already sent lines are not kept in memory.