Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xxxKeyValue() variants with KeyValue to ObservationContextAssert #4038

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Aug 19, 2023

While working on #4037, xxxKeyValue() variants with KeyValue in ObservationContextAssert seem to be useful, so this PR adds them.

@marcingrzejszczak
Copy link
Contributor

Great idea, I'm really surprised that we've forgotten to add it earlier. Thanks!

@marcingrzejszczak marcingrzejszczak added the enhancement A general enhancement label Aug 21, 2023
@marcingrzejszczak marcingrzejszczak added this to the 1.12.0-M3 milestone Aug 21, 2023
@marcingrzejszczak marcingrzejszczak merged commit a2ad7e1 into micrometer-metrics:main Aug 21, 2023
@izeye izeye deleted the key-value-variants branch August 21, 2023 11:13
izeye added a commit to izeye/micrometer that referenced this pull request Aug 21, 2023
izeye added a commit to izeye/micrometer that referenced this pull request Aug 21, 2023
izeye added a commit to izeye/micrometer that referenced this pull request Aug 21, 2023
shakuzen pushed a commit to izeye/micrometer that referenced this pull request Feb 5, 2024
shakuzen pushed a commit to izeye/micrometer that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants