Add history-tracking to ObservationValidator #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lets you peek into the history of certain interactions with your Observations if an InvalidObservationException is thrown. This includes which method was called on your Observations (start, stop, error, etc) and also the relevant part of the stack trace. InvalidObservationException can provide you the full history through its getHistory method and it also gives you a summary through its toString.
shakuzen
approved these changes
Aug 8, 2024
jonatan-ivanov
added a commit
that referenced
this pull request
Aug 8, 2024
Merged
jonatan-ivanov
pushed a commit
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets you peek into the history of certain interactions with your
Observations if anInvalidObservationExceptionis thrown. This includes which method was called on yourObservations (start,stop,error, etc) and also the relevant part of the stack trace. This is helpful when the instrumentation is complex and it is not apparent where a previous call to Observation happened that needs to be fixed.InvalidObservationExceptioncan provide you the full history through itsgetHistorymethod and it also gives you a summary through itstoString, something like this: